mirror of
https://github.com/truecharts/library-charts.git
synced 2026-07-03 03:19:18 -03:00
7fbf55aa71
There is a design mistake in the probe setup: Liveness probe: Stops the container on failure, this should happen AFTER readiness probe detects failure. Readiness Probe: Stops the service forwarding traffic. This should happen BEFORE the liveness probe detects failure Startup Probe: By having a tcp startup-probe, charts might pass CI when not fully working. or, worse, get passed-over to the readiness/liveness probes when the container is still doing maintenance work (such as plex database updates). Leading to it right-away being thrown-out by liveness/readyness
Library Chart
Helm Library Chart for TrueCharts Charts and Apps
Feature addition(s) or enhancements
Please first discuss with us the feature you want to add, especially if it's a large one. This is to ensure we have an extendable and maintainable implementation!
Keep in mind that both docs and unit tests are required in order to complete/merge the feature addition or enhancement.
Bug fixes
Bug fixes should also be covered by a test case for that scenario. No PRs will be accepted without this.
Contributions
- Any kind of change (feature or bug fix) that alters/adds/removes a key in the values structure have to also be documented
- Additionally, unit tests must be added to cover the change, and if a migration is needed, must be added at the PR description.
Both are a hard requirement.
- Adding dependency handlers in the library chart, would assume that a dependency chart is already implemented and merged in the charts repo.