mirror of https://github.com/truecharts/library-charts.git synced 2026-07-03 07:09:15 -03:00

Go to file

Stavros Kois 7072cbe4be fix(codeserver): don't try to mount a volume if it's target on a specific container (#416 )

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  https://github.com/truecharts/charts/issues/8694

When there is a `targetSelector` defined, don't try to mount this volume
to codeserver. As it's most likely a configmap/secret or a volume only
relevant to a specific container

eg:
```yaml
persistence:
  init:
    enabled: true
    type: configmap
    objectName: init
    mountPath: "/config/init"
    defaultMode: "0777"
    readOnly: true
    targetSelector:
      main:
        init: {}
```
But the caveat is that also this wont be mounted:
```yaml
persistence:
  vol:
    enabled: true
    type: emptyDir
    mountPath: "/config/init"
    targetSelector:
      main:
        main: {}
```

TL;DR only volumes without a selector or a selector with
`targetSelectAll` will be mounted to codeserver.

Not sure what we could do on scale GUI to make this more flexible. Needs
more thought.
But this is a quick fix for now.


**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._