more

library/common-test/tests/ingress/homepage_test.yaml

@@ -181,3 +181,25 @@ tests:
     asserts:
       - failedTemplate:
           errorMessage: Ingress - Expected [integrations.homepage.widget.customkv] to be a [slice], but got [string]
+
+  - it: should fail with customkv having empty key
+    set:
+      operator: *operator
+      service: *service
+      ingress:
+        my-ingress1:
+          enabled: true
+          primary: true
+          integrations:
+            traefik:
+              enabled: false
+            homepage:
+              enabled: true
+              widget:
+                customkv:
+                  - key: ""
+                    value: some-value
+          hosts: *hosts
+    asserts:
+      - failedTemplate:
+          errorMessage: Ingress - Expected non-empty [key] in [integrations.homepage.widget.customkv]

library/common/templates/lib/ingress/integrations/_homepage.tpl

@@ -80,5 +80,10 @@
     {{- if not (kindIs "slice" $homepage.widget.customkv) -}}
       {{- fail (printf "Ingress - Expected [integrations.homepage.widget.customkv] to be a [slice], but got [%s]" (kindOf $homepage.widget.customkv)) -}}
     {{- end -}}
+    {{- range $item := $homepage.widget.customkv -}}
+      {{- if not $item.key -}}
+        {{- fail "Ingress - Expected non-empty [key] in [integrations.homepage.widget.customkv]" -}}
+      {{- end -}}
+    {{- end -}}
   {{- end -}}
 {{- end -}}