c0ff8684ce
**Description**
This PR builds up on #40000 by adding an additional key -
`credentials.$name.customCASecretRef`. This allows referencing secrets
via the already familiar `configMapRef`/`secretRef` pattern, using the
`name` and `expandObjectName` keys to reference secrets defined under
`.Values.secret`. Additionally, it also adds a
`credentials.$name.customCASecretRef.key` forcing users to specify the
key in the secret which contains the CA, for maximum flexibility.
⚒️ Fixes # <!--(issue)-->
**⚙️ Type of change**
- [X] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code
- [X] 📜 Documentation Changes
**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
I tested rendering the same CA secret using both the current `customCA`
implementation and the new `.secret.$name` + `customCASecretRef` way.
Also added unit tests for CI.
**📃 Notes:**
Regarding CNPG support - the changes in this PR and from #40000 should
also work for CNPG. As far as i can tell it requires the CA secret to be
referenced under a key called `endpointCA` in the following way
([docs](https://cloudnative-pg.io/documentation/1.16/api_reference/#backupstatus),
[CRD
def](6ae2fb61be/config/crd/bases/postgresql.cnpg.io_backups.yaml (L256))):
```yaml
...
barmanObjectStore:
endpointURL: ...
...
endpointCA:
name: secret-name
key: secret-key
```
Note that while the current [in-tree barman cloud support is being
deprecated in favour of a barman cloud
plugin](https://cloudnative-pg.io/releases/cloudnative-pg-1-26.0-released/#barman-cloud-deprecation-begins),
the [migration
guide](https://cloudnative-pg.io/plugin-barman-cloud/docs/migration/)
says the new `ObjectStore` CRD has a **direct mapping** between it and
the legacy `barmanObjectStore`. Therefore, the example above can be
translated to:
```yaml
apiVersion: barmancloud.cnpg.io/v1
kind: ObjectStore
...
spec:
configuration:
endpointURL: ...
...
endpointCA:
name: secret-name
key: secret-key
```
**✔️ Checklist:**
- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [X] 📄 I have made changes to the documentation
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning
- [X] I made sure the title starts with `feat(chart-name):`,
`fix(chart-name):`, `chore(chart-name):`, `docs(chart-name):` or
`fix(docs):`
**➕ App addition**
If this PR is an app addition please make sure you have done the
following.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`
---
_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
---------
Signed-off-by: Kjeld Schouten <info@kjeldschouten.nl>
Co-authored-by: Kjeld Schouten <info@kjeldschouten.nl>
title
| title |
|---|
| TrueCharts |
Community Helm Chart Catalog
TrueCharts is a catalog of highly optimised Helm Charts. Made for the community, by the community!
All our charts are supposed to work together and be easy to setup using any helm-compatible deployment tool, above all, give the average user more than enough options to tune things to their liking.
Getting started using TrueCharts
Support
Please check our FAQ, manual and Issue tracker There is a significant chance your issue has been reported before!
Still something not working as expected? Contact us! and we'll figure it out together!
Development
Our development process is fully distributed and agile, so every chart-maintainer is free to set their own roadmap and development speed and does not have to comply to a centralised roadmap. This ensures freedom and flexibility for everyone involved and makes sure you, the end user, always has the latest and greatest of every Chart installed.
Getting into creating Charts
For more information check the website: https://truecharts.org
Contact and Support
To contact the TrueCharts project:
-
Create an issue on Github issues
-
Open a Support Ticket
-
Send us an email
Contributors ✨
Thanks goes to these wonderful people (emoji key):
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?v=4?s=100)
![allcontributors[bot]](https://avatars.githubusercontent.com/in/23186?v=4?s=100)
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?v=4?s=100)
This project follows the all-contributors specification. Contributions of any kind welcome!
Licence
Truecharts, is primarily based on the AGPL-v3 license, this ensures almost everyone can use and modify our charts. Licences can vary on a per-Chart basis. This can easily be seen by the presence of a "LICENSE" file in that folder.
An exception to this, has been made for every document inside folders labeled as docs or doc and their subfolders: those folders are not licensed under AGPL-v3 and are considered "all rights reserved". Said content can be modified and changes submitted per PR, in accordance to the github End User License Agreement.
SPDX-License-Identifier: AGPL-3.0
