mirror of
https://github.com/truecharts/library-charts.git
synced 2026-07-03 11:04:34 -03:00
2de60ea721
**Description** There is a design mistake in the probe setup: Liveness probe: Stops the container on failure, this should happen AFTER readiness probe detects failure. Readiness Probe: Stops the service forwarding traffic. This should happen BEFORE the liveness probe detects failure Startup Probe: By having a tcp startup-probe, charts might pass CI when not fully working. or, worse, get passed-over to the readiness/liveness probes when the container is still doing maintenance work (such as plex database updates). Leading to it right-away being thrown-out by liveness/readyness I also attempted to offset start of liveness and readyness, this ensures they don't send probes at the same time, while making it most-likely that liveness clears before readiness on startup. While also offsetting the intervals, to prevent the same while running **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [x] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> **📃 Notes:** <!-- Please enter any other relevant information here --> **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning - [ ] I made sure the title starts with `feat(chart-name):`, `fix(chart-name):` or `chore(chart-name):` **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._
Common Library
Naming Scheme
- ServiceAccount:
- Primary:
$FullName - Others:
$FullName-$ServiceAccountName
- Primary:
- RBAC:
- Primary:
$FullName - Others:
$FullName-$RBACName
- Primary:
- Service:
- Primary:
$FullName - Others:
$FullName-$ServiceName
- Primary:
- Pods:
- Primary:
$FullName - Others:
$FullName-$PodName
- Primary:
- Containers:
$ContainerName - ConfigMap:
$FullName-$ConfigMapName - Secret:
$FullName-$SecretName - Scale External Interface:
ix-$ReleaseName-$index
Full name ->
$ReleaseName-$ChartNameAny name that exceeds 63 characters, will throw an error