mirror of
https://github.com/truecharts/library-charts.git
synced 2026-07-04 22:11:24 -03:00
07d4558f5e
**Description** <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ⚒️ Fixes #441 - Added a function to "generate" the namespace and also validate in terms of length and format. Current blockers: Some objects added after the initial refactor use a different code style and currently is not straightforward to use the above function. Those will have to be revisited once they have some tests for themselves. And after everything else is working and have tests in place (in regards with the namespace change) TODO: - [x] adjusts regex for validation on name and namespace. - [x] Doc updates Tests: - [x] Configmap - [x] CronJob - [x] DaemonSet - [x] Deployment - [x] Endpoint - [x] EndpointSlice - [x] Job - [x] NetworkAttachmentDefinition (Due to being only used in Scale and the way the config is fetched, only global and root level namespaces are used. You just can't define the NS on the object itself.) - [x] PesistentVolumeClaim - [x] RBAC - [x] Secret - [x] Service - [x] ServiceAccount - [x] StatefulSet Objects with the implementation (but no tests): Also those objects do not have per object override and do not support TPL. The above issues will be fixed on each one after they are refactored. - [x] Certificate - [x] Cluster - [x] Pooler - [x] HorizontalPodAutoscaler - [x] Ingress - [x] NetworkPolicy - [x] PodMonitor - [x] PrometheusRule - [x] Route - [x] ServiceMonitor **⚙️ Type of change** - [x] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> **📃 Notes:** <!-- Please enter any other relevant information here --> **✔️ Checklist:** - [x] ⚖️ My code follows the style guidelines of this project - [x] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [x] 📄 I have made corresponding changes to the documentation - [x] ⚠️ My changes generate no new warnings - [x] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [x] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._
302 lines
7.8 KiB
YAML
302 lines
7.8 KiB
YAML
suite: rbac validation test
|
|
templates:
|
|
- common.yaml
|
|
release:
|
|
name: test-release-name
|
|
namespace: test-release-namespace
|
|
tests:
|
|
- it: should fail with name longer than 63 characters
|
|
set:
|
|
rbac:
|
|
zmy-rbac:
|
|
enabled: true
|
|
primary: true
|
|
my-rbac-has-super-long-name-that-is-longer-than-63-characters-too-bad:
|
|
enabled: true
|
|
primary: false
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: Name [test-release-name-common-test-my-rbac-has-super-long-name-that-is-longer-than-63-characters-too-bad] is not valid. Must start and end with an alphanumeric lowercase character. It can contain '-'. And must be at most 63 characters.
|
|
|
|
- it: should fail with name starting with underscore
|
|
set:
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
rules:
|
|
- apiGroups:
|
|
- ""
|
|
resources:
|
|
- pods
|
|
verbs:
|
|
- get
|
|
_my-rbac2:
|
|
enabled: true
|
|
primary: false
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: Name [test-release-name-common-test-_my-rbac2] is not valid. Must start and end with an alphanumeric lowercase character. It can contain '-'. And must be at most 63 characters.
|
|
|
|
- it: should fail with labels not a dict
|
|
set:
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
labels: "not a dict"
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - Expected <labels> to be a dictionary, but got [string]
|
|
|
|
- it: should fail with annotations not a dict
|
|
set:
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
annotations: "not a dict"
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - Expected <annotations> to be a dictionary, but got [string]
|
|
|
|
- it: should fail with more than 1 primary rbac
|
|
set:
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
my-rbac2:
|
|
enabled: true
|
|
primary: true
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - Only one rbac can be primary
|
|
|
|
- it: should fail without any primary on enabled rbac
|
|
set:
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: false
|
|
my-rbac2:
|
|
enabled: true
|
|
primary: false
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - At least one enabled rbac must be primary
|
|
|
|
- it: should fail without rules in rbac
|
|
set:
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - Expected non-empty <rbac.rules>
|
|
|
|
- it: should fail without apiGroups in rules in rbac
|
|
set:
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
rules:
|
|
- resources:
|
|
- pods
|
|
verbs:
|
|
- get
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - Expected non-empty <rbac.rules.apiGroups>
|
|
|
|
- it: should fail without resources in rules in rbac
|
|
set:
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
rules:
|
|
- apiGroups:
|
|
- ""
|
|
verbs:
|
|
- get
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - Expected non-empty <rbac.rules.resources>
|
|
|
|
- it: should fail without verbs in rules in rbac
|
|
set:
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
rules:
|
|
- apiGroups:
|
|
- ""
|
|
resources:
|
|
- pods
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - Expected non-empty <rbac.rules.verbs>
|
|
|
|
- it: should fail with empty entry in resources in rules in rbac
|
|
set:
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
rules:
|
|
- apiGroups:
|
|
- ""
|
|
resources:
|
|
- pods
|
|
- ""
|
|
verbs:
|
|
- get
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - Expected non-empty entry in <rbac.rules.resources>
|
|
|
|
- it: should fail with empty entry in verbs in rules in rbac
|
|
set:
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
rules:
|
|
- apiGroups:
|
|
- ""
|
|
resources:
|
|
- pods
|
|
verbs:
|
|
- get
|
|
- ""
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - Expected non-empty entry in <rbac.rules.verbs>
|
|
|
|
- it: should fail with empty kind in subjects in rbac
|
|
set:
|
|
serviceAccount:
|
|
my-service-account:
|
|
enabled: true
|
|
primary: true
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
rules:
|
|
- apiGroups:
|
|
- ""
|
|
resources:
|
|
- pods
|
|
verbs:
|
|
- get
|
|
subjects:
|
|
- kind: ""
|
|
name: my-name
|
|
apiGroup: my-apiGroup
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - Expected non-empty <rbac.subjects.kind>
|
|
|
|
- it: should fail with empty name in subjects in rbac
|
|
set:
|
|
serviceAccount:
|
|
my-service-account:
|
|
enabled: true
|
|
primary: true
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
rules:
|
|
- apiGroups:
|
|
- ""
|
|
resources:
|
|
- pods
|
|
verbs:
|
|
- get
|
|
subjects:
|
|
- kind: my-kind
|
|
name: ""
|
|
apiGroup: my-apiGroup
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - Expected non-empty <rbac.subjects.name>
|
|
|
|
- it: should fail with empty apiGroup in subjects in rbac
|
|
set:
|
|
serviceAccount:
|
|
my-service-account:
|
|
enabled: true
|
|
primary: true
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
rules:
|
|
- apiGroups:
|
|
- ""
|
|
resources:
|
|
- pods
|
|
verbs:
|
|
- get
|
|
subjects:
|
|
- kind: my-kind
|
|
name: my-name
|
|
apiGroup: ""
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - Expected non-empty <rbac.subjects.apiGroup>
|
|
|
|
- it: should fail with namespace longer than 63 characters
|
|
set:
|
|
serviceAccount:
|
|
my-sa:
|
|
enabled: true
|
|
primary: true
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
namespace: my-extra-super-duper-long-name-that-is-longer-than-63-characters
|
|
rules:
|
|
- apiGroups:
|
|
- ""
|
|
resources:
|
|
- pods
|
|
verbs:
|
|
- get
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - Namespace [my-extra-super-duper-long-name-that-is-longer-than-63-characters] is not valid. Must start and end with an alphanumeric lowercase character. It can contain '-'. And must be at most 63 characters.
|
|
|
|
- it: should fail with namespace not starting with [ix-] in TrueNAS SCALE
|
|
set:
|
|
global:
|
|
ixChartContext:
|
|
iAmNotEmpty: true
|
|
serviceAccount:
|
|
my-sa:
|
|
enabled: true
|
|
primary: true
|
|
namespace: ix-namespace
|
|
rbac:
|
|
my-rbac:
|
|
enabled: true
|
|
primary: true
|
|
namespace: my-namespace
|
|
rules:
|
|
- apiGroups:
|
|
- ""
|
|
resources:
|
|
- pods
|
|
verbs:
|
|
- get
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: RBAC - Namespace [my-namespace] expected to have [ix-] prefix when installed in TrueNAS SCALE
|