From ec290f2d23e628a67424011ddbc70e8cd1f95865 Mon Sep 17 00:00:00 2001
From: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Date: Mon, 31 Jul 2023 12:36:40 +0200
Subject: [PATCH] chore(common): hardfail with clear error when required
 operators are not found.

---
 library/common/Chart.yaml                              | 2 +-
 library/common/templates/lib/util/_verify_operator.tpl | 2 +-
 library/common/values.yaml                             | 3 +--
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/library/common/Chart.yaml b/library/common/Chart.yaml
index 0420c0d7..e9446ff3 100644
--- a/library/common/Chart.yaml
+++ b/library/common/Chart.yaml
@@ -15,4 +15,4 @@ maintainers:
 name: common
 sources: null
 type: library
-version: 13.2.2
+version: 14.0.0
diff --git a/library/common/templates/lib/util/_verify_operator.tpl b/library/common/templates/lib/util/_verify_operator.tpl
index d3b68a4e..305db274 100644
--- a/library/common/templates/lib/util/_verify_operator.tpl
+++ b/library/common/templates/lib/util/_verify_operator.tpl
@@ -40,7 +40,7 @@
       {{- if eq $fetchedOpData "false" -}}
         {{/* Fail only if explicitly asked */}}
         {{- if $.Values.operator.verify.failOnError -}}
-          {{- fail (printf "Operator [%s] have to be installed first" $opName) -}}
+          {{- fail (printf "Operator [%s] has to be installed first" $opName) -}}
         {{- end -}}
       {{/* If $fetchedOpData is not false, we should have JSON data */}}
       {{- else -}}
diff --git a/library/common/values.yaml b/library/common/values.yaml
index f07c3ba3..d2714e71 100644
--- a/library/common/values.yaml
+++ b/library/common/values.yaml
@@ -582,8 +582,7 @@ operator:
   verify:
     enabled: true
     # -- Makes non-found operators hard-failing
-    ## TODO: set to true
-    failOnError: false
+    failOnError: true
     # -- a list of extra operators to check for
     additionalOperators: []
   ## -- used as a datastore when a metallb operator is found.