feat(common): write a different check for crd/operator presence (#714)

**Description**
We want to get rid of VerifyOperator code, in favor of code that can
work both with our helm charts and helm charts from other sources.
This does not replace verify-operator **yet** but at least implements a
new way of checking for crd presence, which is the main goal of
verifyOperator

**⚙️ Type of change**

- [x] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [ ] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
This commit is contained in:
Kjeld Schouten
2024-02-26 21:08:39 +01:00
committed by GitHub
parent dcda3ad581
commit 8ae103c889
20 changed files with 60 additions and 24 deletions

View File

@@ -1,6 +1,6 @@
remote: origin
target-branch: master
helm-extra-args: --debug
helm-extra-args: --debug --set crd.verify.enabled=false
chart-yaml-schema: .github/ct-install-config/chart_schema.yaml
chart-dirs:
- library

View File

@@ -92,7 +92,7 @@ jobs:
# Run tests
cd library/common-test/
helm dependency update
helm unittest -f "tests/**/*.yaml" .
helm unittest -f "tests/**/*.yaml" . -v ./unit-values.yaml
install:
needs: