From ce3dafb8e9b88bb5a5d0785e2652b8de7c7d242f Mon Sep 17 00:00:00 2001 From: Stavros Kois <47820033+stavros-k@users.noreply.github.com> Date: Mon, 1 May 2023 10:33:43 +0300 Subject: [PATCH] chore(templates): hostnet+dnsconfig behind expert (#8635) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** ⚒️ Fixes #8633 **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [x] ⚖️ My code follows the style guidelines of this project - [x] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [x] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- templates/questions/general/podOptions.yaml | 95 +++++++++++---------- 1 file changed, 51 insertions(+), 44 deletions(-) diff --git a/templates/questions/general/podOptions.yaml b/templates/questions/general/podOptions.yaml index a1b917ee2fb..d7dbeceb227 100644 --- a/templates/questions/general/podOptions.yaml +++ b/templates/questions/general/podOptions.yaml @@ -5,57 +5,64 @@ additional_attrs: true type: dict attrs: - - variable: hostNetwork - label: "Host Networking" + - variable: expertPodOpts + label: "Expert - Pod Options" schema: type: boolean default: false - - variable: dnsConfig - label: "DNS Configuration" - schema: - type: dict - additional_attrs: true - attrs: - - variable: options - label: "Options" + show_subquestions_if: true + subquestions: + - variable: hostNetwork + label: "Host Networking" schema: - type: list - default: [{"name": "ndots", "value": "2"}] - items: - - variable: optionsEntry - label: "Option Entry" + type: boolean + default: false + - variable: dnsConfig + label: "DNS Configuration" + schema: + type: dict + additional_attrs: true + attrs: + - variable: options + label: "Options" schema: - type: dict - additional_attrs: true - attrs: - - variable: name - label: "Name" + type: list + default: [{"name": "ndots", "value": "2"}] + items: + - variable: optionsEntry + label: "Option Entry" + schema: + type: dict + additional_attrs: true + attrs: + - variable: name + label: "Name" + schema: + type: string + required: true + - variable: value + label: "Value" + schema: + type: string + - variable: nameservers + label: "Nameservers" + schema: + type: list + default: [] + items: + - variable: nsEntry + label: "Nameserver Entry" schema: type: string required: true - - variable: value - label: "Value" + - variable: searches + label: "Searches" + schema: + type: list + default: [] + items: + - variable: searchEntry + label: "Search Entry" schema: type: string - - variable: nameservers - label: "Nameservers" - schema: - type: list - default: [] - items: - - variable: nsEntry - label: "Nameserver Entry" - schema: - type: string - required: true - - variable: searches - label: "Searches" - schema: - type: list - default: [] - items: - - variable: searchEntry - label: "Search Entry" - schema: - type: string - required: true + required: true