From cb5464473822b10039a452a205fa478d6fa94f06 Mon Sep 17 00:00:00 2001
From: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com>
Date: Mon, 27 Nov 2023 16:51:31 -0500
Subject: [PATCH] feat(minecraft-java) update image tag and add NeoForge server
 type (#15424)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
Fix the image tag and add NeoForge as a server type.
⚒️ Fixes  #15287

**⚙️ Type of change**

- [X] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
---
 charts/stable/minecraft-java/Chart.yaml     | 2 +-
 charts/stable/minecraft-java/questions.yaml | 8 ++++++++
 charts/stable/minecraft-java/values.yaml    | 2 +-
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/charts/stable/minecraft-java/Chart.yaml b/charts/stable/minecraft-java/Chart.yaml
index 7265d3fa0af..264a4e8734f 100644
--- a/charts/stable/minecraft-java/Chart.yaml
+++ b/charts/stable/minecraft-java/Chart.yaml
@@ -21,7 +21,7 @@ sources:
   - https://github.com/truecharts/charts/tree/master/charts/stable/minecraft-java
   - https://github.com/itzg/docker-minecraft-server
 type: application
-version: 5.1.1
+version: 5.1.2
 annotations:
   truecharts.org/category: games
   truecharts.org/SCALE-support: "true"
diff --git a/charts/stable/minecraft-java/questions.yaml b/charts/stable/minecraft-java/questions.yaml
index a7176cf1358..5f5a15e4552 100644
--- a/charts/stable/minecraft-java/questions.yaml
+++ b/charts/stable/minecraft-java/questions.yaml
@@ -89,6 +89,8 @@ questions:
                                               description: Vanilla
                                             - value: FORGE
                                               description: Forge
+                                            - value: NEOFORGE
+                                              description: NeoForge
                                             - value: FABRIC
                                               description: Fabric
                                             - value: SPIGOT
@@ -185,6 +187,12 @@ questions:
                                           type: string
                                           default: ""
                                           show_if: [[TYPE, "=", "FORGE"]]
+                                      - variable: NEOFORGE_VERSION
+                                        label: NeoForge Version
+                                        schema:
+                                          type: string
+                                          default: "47.1.79"
+                                          show_if: [[TYPE, "=", "NEOFORGE"]]
                                       - variable: FABRIC_LOADER_VERSION
                                         label: Fabric Loader Version
                                         schema:
diff --git a/charts/stable/minecraft-java/values.yaml b/charts/stable/minecraft-java/values.yaml
index 2edb0e6490f..2fd770125d8 100644
--- a/charts/stable/minecraft-java/values.yaml
+++ b/charts/stable/minecraft-java/values.yaml
@@ -1,6 +1,6 @@
 image:
   repository: itzg/minecraft-server
-  tag: 2023.8.3@sha256:2af12eac3a7106882e23d1b2435358db841c4302d213532e415255fbbd36c826
+  tag: 2023.11.1@sha256:cb98ad8c143ab0cf83351ec6a9fd76256152f7b310988f9aa1acfaaf4aacbc77
   pullPolicy: Always
 j21Image:
   repository: itzg/minecraft-server