From 7d6ff34049e9f709fa18e75590f2be6eafecc11d Mon Sep 17 00:00:00 2001 From: Alec Fenichel Date: Fri, 23 Feb 2024 05:00:54 -0500 Subject: [PATCH] feat(cert-manager) add SCALE GUI for dns01RecursiveNameserversOnly (#18493) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** ⚒️ Fixes # Adds support for the `dns01RecursiveNameserversOnly` flag as described here: https://cert-manager.io/docs/configuration/acme/dns01/#setting-nameservers-for-dns01-self-check. **⚙️ Type of change** - [x] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [x] ⚖️ My code follows the style guidelines of this project - [x] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [x] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [x] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: Kjeld Schouten Co-authored-by: Kjeld Schouten --- charts/operators/cert-manager/Chart.yaml | 2 +- charts/operators/cert-manager/questions.yaml | 13 +++++++++++++ charts/operators/cert-manager/values.yaml | 1 + 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/charts/operators/cert-manager/Chart.yaml b/charts/operators/cert-manager/Chart.yaml index cbf3283dfe3..25275f1a579 100644 --- a/charts/operators/cert-manager/Chart.yaml +++ b/charts/operators/cert-manager/Chart.yaml @@ -43,4 +43,4 @@ sources: - https://github.com/truecharts/charts/tree/master/charts/operators/cert-manager - https://github.com/truecharts/containers/tree/master/apps/alpine type: application -version: 3.4.0 +version: 3.5.0 diff --git a/charts/operators/cert-manager/questions.yaml b/charts/operators/cert-manager/questions.yaml index 51f2165fdd5..6ed4827ee9b 100644 --- a/charts/operators/cert-manager/questions.yaml +++ b/charts/operators/cert-manager/questions.yaml @@ -19,3 +19,16 @@ questions: type: string required: true default: "1.1.1.1:53,1.0.0.1:53" + - variable: dns01RecursiveNameserversOnly + label: DNS01 Recursive Nameservers Only (Modifications are unsupported) + description: | + Forces cert-manager to only use the recursive nameservers for verification. + Enabling this option could cause the DNS01 self check to take longer + due to caching performed by the recursive nameservers. + Default is: false
+ If this is modified, you are NOT covered by support. + schema: + type: boolean + required: true + default: false + diff --git a/charts/operators/cert-manager/values.yaml b/charts/operators/cert-manager/values.yaml index 210942c0124..28b18caf84c 100644 --- a/charts/operators/cert-manager/values.yaml +++ b/charts/operators/cert-manager/values.yaml @@ -23,6 +23,7 @@ operator: certmanager: dns01RecursiveNameservers: "1.1.1.1:53,1.0.0.1:53" + dns01RecursiveNameserversOnly: false installCRDs: true enableCertificateOwnerRef: true