From 1e2f48b5e90368938b0a6893c8b91ccf31bf5dc6 Mon Sep 17 00:00:00 2001
From: Rickard <grvn@users.noreply.github.com>
Date: Thu, 15 Jun 2023 15:41:10 -0400
Subject: [PATCH] fix(Transmission):  Fix PodCIDR whitelist (#9662)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # 9186
**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**

**📃 Notes:**
Issue 9186 seems to be triggered by the change of scope ( see
[link](https://helm.sh/docs/chart_template_guide/control_structures/#modifying-scope-using-with)
for documentation and example ) in Helm `with` action which occur on
line 14 in `charts/stable/transmission/templates/common.yaml` and is not
reflected on line 15 and 17 use of `.Values`.

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [x] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Co-authored-by: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com>
---
 charts/stable/transmission/Chart.yaml            | 2 +-
 charts/stable/transmission/templates/common.yaml | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/charts/stable/transmission/Chart.yaml b/charts/stable/transmission/Chart.yaml
index e426ffc49ce..363776e2887 100644
--- a/charts/stable/transmission/Chart.yaml
+++ b/charts/stable/transmission/Chart.yaml
@@ -22,7 +22,7 @@ sources:
   - https://github.com/truecharts/charts/tree/master/charts/stable/transmission
   - https://github.com/transmission/transmission
 type: application
-version: 16.0.25
+version: 16.0.26
 annotations:
   truecharts.org/catagories: |
     - download-tools
diff --git a/charts/stable/transmission/templates/common.yaml b/charts/stable/transmission/templates/common.yaml
index cf19cc0dca8..ff3cc61a211 100644
--- a/charts/stable/transmission/templates/common.yaml
+++ b/charts/stable/transmission/templates/common.yaml
@@ -12,9 +12,9 @@
 {{- end -}}
 
 {{- with .Values.workload.main.podSpec.containers.main.env.TRANSMISSION_RPC_WHITELIST -}}
-  {{- if not (contains .Values.chartContext.podCIDR .) }}
+  {{- if not (contains $.Values.chartContext.podCIDR .) }}
     {{/* Append CIDR in front */}}
-    {{- $_ := set $.Values.workload.main.podSpec.containers.main.env.TRANSMISSION_RPC_WHITELIST (printf "%v,%v" .Values.chartContext.podCIDR .) }}
+    {{- $_ := set $.Values.workload.main.podSpec.containers.main.env.TRANSMISSION_RPC_WHITELIST (printf "%v,%v" $.Values.chartContext.podCIDR .) }}
   {{- end }}
 {{- end -}}