From 12c48791a9c1f1b576808034cfd99f45fcd97f4d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alfred=20G=C3=B6ppel?= <43101280+alfi0812@users.noreply.github.com> Date: Sat, 7 Jun 2025 13:13:46 +0200 Subject: [PATCH] feat(external-dns): add ingressclass feature (#36064) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** ⚒️ Fixes https://github.com/truecharts/public/issues/35586 **⚙️ Type of change** - [x] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code - [ ] 📜 Documentation Changes **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [x] ⚖️ My code follows the style guidelines of this project - [x] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made changes to the documentation - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [x] ⬆️ I increased versions for any altered app according to semantic versioning - [x] I made sure the title starts with `feat(chart-name):`, `fix(chart-name):`, `chore(chart-name):`, `docs(chart-name):` or `fix(docs):` **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/stable/external-dns/Chart.yaml | 2 +- charts/stable/external-dns/templates/_args.tpl | 3 +++ charts/stable/external-dns/values.yaml | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/charts/stable/external-dns/Chart.yaml b/charts/stable/external-dns/Chart.yaml index 1996070a198..e9fb4722b8b 100644 --- a/charts/stable/external-dns/Chart.yaml +++ b/charts/stable/external-dns/Chart.yaml @@ -36,5 +36,5 @@ sources: - https://github.com/kubernetes-sigs/external-dns - https://github.com/truecharts/charts/tree/master/charts/stable/external-dns type: application -version: 6.9.0 +version: 6.10.0 diff --git a/charts/stable/external-dns/templates/_args.tpl b/charts/stable/external-dns/templates/_args.tpl index d79a3918729..ca9521d7b45 100644 --- a/charts/stable/external-dns/templates/_args.tpl +++ b/charts/stable/external-dns/templates/_args.tpl @@ -1,5 +1,8 @@ {{- define "externaldns.args" -}} args: + {{- with .Values.externaldns.ingressClassName }} + - --ingress-class={{ . }} + {{- end -}} {{- with .Values.externaldns.provider }} - --provider={{ . }} {{- end -}} diff --git a/charts/stable/external-dns/values.yaml b/charts/stable/external-dns/values.yaml index 6ad85961adc..73ad20ba8ed 100644 --- a/charts/stable/external-dns/values.yaml +++ b/charts/stable/external-dns/values.yaml @@ -3,6 +3,7 @@ image: pullPolicy: IfNotPresent tag: v0.17.0@sha256:85eba2727b410c8f8093d641a4b1a29671878db94d525a70a4108d10ba8eef5f externaldns: + ingressClassName: "" logLevel: "info" logFormat: "text" interval: "1m"