From 116e2c7560275ccbc07d52480aa16d2627d5f829 Mon Sep 17 00:00:00 2001 From: kqmaverick <121722567+kqmaverick@users.noreply.github.com> Date: Sat, 11 Nov 2023 09:51:48 -0800 Subject: [PATCH] migrate(multi-scrobbler): common update (#14576) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Update to new common. ⚒️ Fixes # **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: kqmaverick <121722567+kqmaverick@users.noreply.github.com> Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com> Co-authored-by: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com> Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com> --- charts/incubator/multi-scrobbler/Chart.yaml | 12 +++---- .../incubator/multi-scrobbler/questions.yaml | 20 ++---------- .../multi-scrobbler/templates/NOTES.txt | 1 + .../multi-scrobbler/templates/common.yaml | 2 +- charts/incubator/multi-scrobbler/values.yaml | 31 +++++++++---------- 5 files changed, 26 insertions(+), 40 deletions(-) create mode 100644 charts/incubator/multi-scrobbler/templates/NOTES.txt diff --git a/charts/incubator/multi-scrobbler/Chart.yaml b/charts/incubator/multi-scrobbler/Chart.yaml index c753a3ad51b..ae64aefc381 100644 --- a/charts/incubator/multi-scrobbler/Chart.yaml +++ b/charts/incubator/multi-scrobbler/Chart.yaml @@ -1,12 +1,9 @@ -annotations: - truecharts.org/SCALE-support: "true" - truecharts.org/category: Network-Web apiVersion: v2 -appVersion: "latest" +appVersion: "0.6.1" dependencies: - name: common repository: https://library-charts.truecharts.org - version: 11.1.2 + version: 14.3.5 deprecated: false description: "Track your music listening history from many sources and record to many scrobble clients." home: https://truecharts.org/charts/incubator/multi-scrobbler @@ -24,4 +21,7 @@ name: multi-scrobbler sources: - https://github.com/truecharts/charts/tree/master/charts/incubator/multi-scrobbler type: application -version: 2.0.11 +version: 3.0.0 +annotations: + truecharts.org/SCALE-support: "true" + truecharts.org/category: Network-Web diff --git a/charts/incubator/multi-scrobbler/questions.yaml b/charts/incubator/multi-scrobbler/questions.yaml index 5c2bbd06620..8939305d363 100644 --- a/charts/incubator/multi-scrobbler/questions.yaml +++ b/charts/incubator/multi-scrobbler/questions.yaml @@ -15,13 +15,7 @@ questions: # Include{containerConfig} # Include{serviceRoot} - - variable: main - label: "Main Service" - description: "The Primary service on which the healthcheck runs, often the webUI" - schema: - additional_attrs: true - type: dict - attrs: +# Include{serviceMain} # Include{serviceSelectorLoadBalancer} # Include{serviceSelectorExtras} - variable: main @@ -42,16 +36,8 @@ questions: # Include{serviceList} # Include{persistenceRoot} - variable: config - label: "config Storage" - description: "Container Path homenodeconfig" - schema: - additional_attrs: true - type: dict - attrs: -# Include{persistenceBasic} - - variable: logs - label: "logs Storage" - description: "Container Path homenodeapplogs" + label: "App Config Storage" + description: "Stores the Application Configuration." schema: additional_attrs: true type: dict diff --git a/charts/incubator/multi-scrobbler/templates/NOTES.txt b/charts/incubator/multi-scrobbler/templates/NOTES.txt new file mode 100644 index 00000000000..c8b2d714d13 --- /dev/null +++ b/charts/incubator/multi-scrobbler/templates/NOTES.txt @@ -0,0 +1 @@ +{{- include "tc.v1.common.lib.chart.notes" $ -}} \ No newline at end of file diff --git a/charts/incubator/multi-scrobbler/templates/common.yaml b/charts/incubator/multi-scrobbler/templates/common.yaml index cbf66c20818..78d963fb168 100644 --- a/charts/incubator/multi-scrobbler/templates/common.yaml +++ b/charts/incubator/multi-scrobbler/templates/common.yaml @@ -1,2 +1,2 @@ {{/* Render the templates */}} -{{ include "tc.common.loader.all" . }} +{{ include "tc.v1.common.loader.all" . }} diff --git a/charts/incubator/multi-scrobbler/values.yaml b/charts/incubator/multi-scrobbler/values.yaml index 4da74f8a1a6..6d43357e0bc 100644 --- a/charts/incubator/multi-scrobbler/values.yaml +++ b/charts/incubator/multi-scrobbler/values.yaml @@ -1,28 +1,27 @@ -env: {} image: pullPolicy: IfNotPresent repository: tccr.io/truecharts/multi-scrobbler - tag: latest@sha256:0e1ff0a7862b0463c743615cb0e26c8dff41f5c0663b22c48439eaf5a798033d -persistence: - config: - enabled: true - mountPath: /home/node/config - logs: - enabled: true - mountPath: /home/node/app/logs -podSecurityContext: - runAsGroup: 0 - runAsUser: 0 + tag: v0.6.1@sha256:a08454006d704a1ca96a6dcb89f28556b636c5f131f58eca37014d54bfd74474 + securityContext: - readOnlyRootFilesystem: false - runAsNonRoot: false + container: + readOnlyRootFilesystem: false + runAsNonRoot: false + runAsGroup: 0 + runAsUser: 0 + service: main: ports: main: port: 9078 - protocol: TCP targetPort: 9078 +persistence: + config: + enabled: true + mountPath: /config + portal: - enabled: true + open: + enabled: true