From 0d7e50b025ca2b91b6b36fd6612ab2eeb3bbfcea Mon Sep 17 00:00:00 2001
From: alfi0812 <43101280+alfi0812@users.noreply.github.com>
Date: Fri, 8 Mar 2024 10:54:44 +0100
Subject: [PATCH] fix(pihole) Fix TCP Port not beeing exposed (#18959)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Should fix the issue that pihole isnt exposing TCP Port

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
Changed it so its identically to Blocky where it works just fine.

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: Kjeld Schouten <info@kjeldschouten.nl>
Co-authored-by: Kjeld Schouten <info@kjeldschouten.nl>
---
 charts/stable/pihole/Chart.yaml  | 2 +-
 charts/stable/pihole/values.yaml | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/charts/stable/pihole/Chart.yaml b/charts/stable/pihole/Chart.yaml
index 3e68a61383d..16a1819c9a9 100644
--- a/charts/stable/pihole/Chart.yaml
+++ b/charts/stable/pihole/Chart.yaml
@@ -35,4 +35,4 @@ sources:
   - https://github.com/truecharts/charts/tree/master/charts/stable/pihole
   - https://hub.docker.com/r/pihole/pihole
 type: application
-version: 16.1.1
+version: 16.1.2
diff --git a/charts/stable/pihole/values.yaml b/charts/stable/pihole/values.yaml
index 83accc622d2..6bdc9124108 100644
--- a/charts/stable/pihole/values.yaml
+++ b/charts/stable/pihole/values.yaml
@@ -54,8 +54,9 @@ service:
         targetPort: 53
       dns-tcp:
         enabled: true
+        protocol: tcp
         port: "{{ .Values.service.dns.ports.dns.port }}"
-        targetPort: "{{ .Values.service.dns.ports.dns.targetPort }}"
+        targetPort: 53
 persistence:
   config:
     enabled: true