Commit Graph

20 Commits

Author SHA1 Message Date
Stavros Kois
702a0c3aba chore(ci): Improved lint speed (#8809)
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

TODO: Switch to scripted checks (To replace ct-list's tasks):
- [x] Helm Lint
- [x] Version Checking
- [x] Run the lint inside the devcontainer (so it have the below tools
available)
- [x] YAML Schema check on Chart.yaml
- [ ] Maintener check on Chart.yaml (Moved to another PR in the future)
- [x] YAML Lint on Chart.yaml
- [x] YAML Lint on values.yaml
- [x] Sort output of lint results (failed on the bottom)
- [x] Combine verify deps in the lint job, since the verification runs
inside the fetch dep (which runs on lint job too)
- [x] Remove one of the 2 "get changed" functions (one based on tags
other on commit)
After that, move linting to single step 


https://github.com/helm/chart-testing/blob/main/pkg/tool/linter.go
https://github.com/helm/chart-testing/blob/main/pkg/tool/account.go

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [x] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [x] 📄 I have made corresponding changes to the documentation
- [x] ⚠️ My changes generate no new warnings
- [x] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
2023-05-23 10:26:41 +02:00
Kjeld Schouten-Lebbing
e7ee7d7176 Update CODEOWNERS
Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
2023-02-10 15:23:27 +01:00
Kjeld Schouten-Lebbing
9836d08cb6 Update CODEOWNERS
Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
2023-02-06 18:47:50 +01:00
Kjeld Schouten-Lebbing
aae8ab21ab Update CODEOWNERS
Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
2023-02-06 18:38:26 +01:00
Kjeld Schouten-Lebbing
32cbcf7e58 Update CODEOWNERS
Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
2023-02-06 18:32:07 +01:00
Kjeld Schouten-Lebbing
5529c2a3af refactor(charts): BREAKING CHANGE (#2836)
* Update Apps with new Common version

* Patch with the secret fixes from common

* fix amd
2022-06-07 19:41:19 +02:00
kjeld Schouten-Lebbing
d04709b0fb try 2 for fixing codeowners 2021-09-04 12:16:16 +02:00
kjeld Schouten-Lebbing
7dcb4d5a12 try adding renovate to codeowners 2021-09-04 12:12:32 +02:00
Kjeld Schouten-Lebbing
243de9fe1b Mostly remove bloated codeowners 2021-08-25 20:26:18 +02:00
kjeld Schouten-Lebbing
9d2c0318f7 Port features from #446 into #477
Co-authored-by: Luuk Nieuwdorp <luuknieuwdorp@users.noreply.github.com>
2021-05-23 18:25:58 +02:00
Lloyd W
0a0b3158a2 Add warllo54 as code owner (#443)
* added warllo54 as a codeowner for fireflyiii and podgrab

* added new line eof
2021-05-07 10:33:09 +02:00
Lloyd
5e3d367368 Appdaemon (#368)
* initial appdaemon commit

* bumped common chart to 3.5.2

* replaced common chart 2.2.2 with 3.5.2

* Updated test-values.yaml

* fixed incorrect name on test_values.yaml

* delete test-values.yam

* fixed chart.yaml maintainers

* refactored Chart.yaml to more closly match other charts.

* removed "depreciated" as it was an unexpected element.

* added new line at end of chart.yaml

* fixed indentation under dependencies for chart.yaml

* more yaml fixes...

* Update incubator/appdaemon/0.1.0/test_values.yaml

accepted proposed changes.

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* addressed remaining comments for ornias

* updated storage for test_values.yaml

* removed ingress false to address comments.

* fixed ingress params.

* updated docker container, added, commented and fixed envs.

* updated tag version#

* fixed tag?

* upated questions to include HA_URL

* fixed env for dash_URL

* added more env varibles and fixed chart.yaml

* change lat,long,elevation to floats

* fixed spelling error.

* added more test values

* fixed run as non root

* fixed timezone settings

* implemented suggested changes

* testing custom storage.

* reverting the last commit

* testing more custom storage.

* questions.yaml added back internal storage, updated mount point, fixed service ports

* removed persistant storage in favor of custom storage.

* attempting to add customer storage to tests, added missing varibles to questions.yaml

* fixed defaults in questions.yaml

* fixed spelling error in questions.yaml and added custom storage to test values

* updated storage questions.yaml to match test_values.yaml

* implemented suggested changes for custom storage

* testing updated questions.yaml

* testing updated questions.yaml

* reverted back custom storage in questions.yaml

* Update incubator/appdaemon/item.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* completed suggested changes from review by  ornias1993

* fixed error under storage in questions.yaml

* fixed linting issues in chart.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
2021-04-30 23:40:20 +02:00
Stavros Kois
4907d65b7a Update CODEOWNERS (#386) 2021-04-21 10:12:42 +02:00
Stavros Kois
35c3dba862 Adds youtubeDL-Material (#372)
* Adds YoutubeDL-Material with some suggestions from @Ornias1993

* test with 1000 user

* change to /data

* change tests to 568 and update docs

* doc update
2021-04-18 00:33:53 +02:00
Luuk Nieuwdorp
65c08dcf30 Add Syncthing (#327)
* Add Syncthing

* fix sonarr reference

* update Chart.lock

* add URL

* update github username (?)

* edit test_values  volumes

* fix chart home

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* remove chart upstream version

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* update sources

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* update maintainers

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* add myself as syncthing maintainer

* use single volume for storage

* fix newline

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
2021-04-12 11:25:07 +02:00
kjeld Schouten-Lebbing
cde18639c7 Post Code-Freeze Review, Bugsfixes and Documentation
- Fix traefik Portal Button
- Touchup Security Policies
- Update Support Policies
- Re-Add Deluge as incubator App
- Add Canary to Security Policies
- Add all-contributors basic config
2021-04-09 13:34:29 +02:00
Dan Sheridan
e6204cdd6f Add Emby (#221)
* Fix FAQ link, add issue tracker link (#226)

The previous faq url points to a 404 page.
Also added a link to the Github issue tracker.

* Simple Emby chart based on the existing Jellyfin chart

* Set current UID and GID environment variables

* Reset the version to match the other charts

* Clean up incorrect version

* Fix versions and maintainer in Chart.yaml# Please enter the commit message for your changes. Lines starting

* Switch to the linuxserver.io Docker image -- it's more closely matched to other Truecharts

* Add end of file \n

* Add back upstream_version (commented out)

* Update CODEOWNERS

* Update Emby for Truecharts 2.0.0

* Update charts/emby/2.0.0/ix_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Update charts/emby/2.0.0/test_values.yaml

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

* Delete Chart.lock

Co-authored-by: Sebastien Dupont <dupont.sebastien@gmail.com>
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
2021-03-08 20:01:18 +00:00
Kjeld Schouten-Lebbing
faad17c656 Add Unifi Controller (#186)
Co-Authored-By: <whiskerz007@users.noreply.github.com>
Co-Authored-By: <kjeld@schouten-lebbing.nl>

Co-authored-by: whiskerz007 <2713522+whiskerz007@users.noreply.github.com>
2021-02-27 19:47:48 +01:00
kjeld Schouten-Lebbing
cb0904478c Add esphome
Co-authored-by: Troy Prelog <tprelog@users.noreply.github.com>
Signed-off-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
2021-02-08 15:28:29 +01:00
kjeld Schouten-Lebbing
7646122f6f Add basic github stuff 2020-12-31 12:47:56 +01:00