From f45ff2940fa041f33102386299fbe785a80ee8a4 Mon Sep 17 00:00:00 2001 From: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com> Date: Fri, 21 Jul 2023 17:03:27 -0400 Subject: [PATCH] feat(lidarr) add exportarr sidecar to lidarr (#10717) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Add exportarr metrics sidecarr to lidarr ⚒️ Fixes # **⚙️ Type of change** - [X] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/stable/lidarr/Chart.yaml | 2 +- charts/stable/lidarr/questions.yaml | 2 + charts/stable/lidarr/values.yaml | 91 ++++++++++++++++++++++++++--- 3 files changed, 85 insertions(+), 10 deletions(-) diff --git a/charts/stable/lidarr/Chart.yaml b/charts/stable/lidarr/Chart.yaml index a4b934f8c0e..7a5c7fff4f7 100644 --- a/charts/stable/lidarr/Chart.yaml +++ b/charts/stable/lidarr/Chart.yaml @@ -22,7 +22,7 @@ sources: - https://github.com/truecharts/charts/tree/master/charts/stable/lidarr - https://github.com/Lidarr/Lidarr type: application -version: 16.0.27 +version: 16.1.0 annotations: truecharts.org/catagories: | - media diff --git a/charts/stable/lidarr/questions.yaml b/charts/stable/lidarr/questions.yaml index 90d20f310e1..51057a4d1e7 100644 --- a/charts/stable/lidarr/questions.yaml +++ b/charts/stable/lidarr/questions.yaml @@ -106,6 +106,8 @@ questions: default: 568 # Include{resources} +# Include{metrics} +# Include{prometheusRule} # Include{advanced} # Include{addons} # Include{codeserver} diff --git a/charts/stable/lidarr/values.yaml b/charts/stable/lidarr/values.yaml index bcca0de36be..4d65f2076de 100644 --- a/charts/stable/lidarr/values.yaml +++ b/charts/stable/lidarr/values.yaml @@ -2,21 +2,30 @@ image: repository: tccr.io/truecharts/lidarr pullPolicy: IfNotPresent tag: v1.3.1.3371@sha256:1cea8b94bc278c6fa20fb15747e8a1c393079e87b8537775d499667795717de6 +exportarrImage: + repository: tccr.io/truecharts/exportarr + pullPolicy: IfNotPresent + tag: v1.5.3@sha256:f369a43b28410f12ce1b96f52187dd5c6fb9769a137ecc6f7ab8fdcfbe7db58e + +securityContext: + container: + readOnlyRootFilesystem: false + service: main: ports: main: port: 8686 -persistence: - config: + metrics: enabled: true - mountPath: /config -portal: - open: - enabled: true -securityContext: - container: - readOnlyRootFilesystem: false + type: ClusterIP + targetSelector: exportarr + ports: + metrics: + enabled: true + port: 8687 + targetSelector: exportarr + workload: main: podSpec: @@ -44,3 +53,67 @@ workload: env: LIDARR__PORT: "{{ .Values.service.main.ports.main.port }}" LIDARR__AUTHENTICATION_METHOD: "" + exportarr: + enabled: true + type: Deployment + strategy: RollingUpdate + replicas: 1 + podSpec: + containers: + exportarr: + primary: true + enabled: true + imageSelector: exportarrImage + args: + - lidarr + probes: + liveness: + enabled: true + type: http + path: /healthz + port: "{{ .Values.service.metrics.ports.metrics.port }}" + readiness: + enabled: true + type: http + path: /healthz + port: "{{ .Values.service.metrics.ports.metrics.port }}" + startup: + enabled: true + type: http + path: /healthz + port: "{{ .Values.service.metrics.ports.metrics.port }}" + env: + INTERFACE: 0.0.0.0 + PORT: "{{ .Values.service.metrics.ports.metrics.port }}" + URL: "http://localhost:{{ .Values.service.main.ports.main.port }}" + # additional metrics (slow) + # ENABLE_ADDITIONAL_METRICS: false + # enable gathering unknown queue items + # ENABLE_UNKNOWN_QUEUE_ITEMS: false + CONFIG: "/config/config.xml" + +persistence: + config: + enabled: true + targetSelector: + main: + main: + mountPath: /config + exportarr: + exportarr: + mountPath: /config + readOnly: true + +metrics: + main: + enabled: true + type: "servicemonitor" + endpoints: + - port: metrics + path: /metrics + prometheusRule: + enabled: false + +portal: + open: + enabled: true