From e2db863f93704a143d10b7947ca6f367a0bfa9d7 Mon Sep 17 00:00:00 2001 From: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com> Date: Thu, 1 Jun 2023 16:01:05 -0400 Subject: [PATCH] feat(romm) move romm to stable (#9314) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** move to stable ⚒️ Fixes # **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [X] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- .github/ct-install.yaml | 2 +- charts/{incubator => stable}/romm/.helmignore | 0 charts/{incubator => stable}/romm/CHANGELOG.md | 0 charts/{incubator => stable}/romm/Chart.yaml | 6 +++--- charts/{incubator => stable}/romm/README.md | 0 .../romm/docs/installation_notes.md | 4 +++- charts/{incubator => stable}/romm/icon.png | Bin charts/{incubator => stable}/romm/questions.yaml | 0 .../{incubator => stable}/romm/templates/NOTES.txt | 0 .../romm/templates/common.yaml | 0 charts/{incubator => stable}/romm/values.yaml | 0 11 files changed, 7 insertions(+), 5 deletions(-) rename charts/{incubator => stable}/romm/.helmignore (100%) rename charts/{incubator => stable}/romm/CHANGELOG.md (100%) rename charts/{incubator => stable}/romm/Chart.yaml (83%) rename charts/{incubator => stable}/romm/README.md (100%) rename charts/{incubator => stable}/romm/docs/installation_notes.md (90%) rename charts/{incubator => stable}/romm/icon.png (100%) rename charts/{incubator => stable}/romm/questions.yaml (100%) rename charts/{incubator => stable}/romm/templates/NOTES.txt (100%) rename charts/{incubator => stable}/romm/templates/common.yaml (100%) rename charts/{incubator => stable}/romm/values.yaml (100%) diff --git a/.github/ct-install.yaml b/.github/ct-install.yaml index 41203803320..28a24826213 100644 --- a/.github/ct-install.yaml +++ b/.github/ct-install.yaml @@ -33,7 +33,7 @@ excluded-charts: - charts/stable/promcord - charts/stable/rdesktop - charts/stable/reg - - charts/incubator/romm + - charts/stable/romm - charts/stable/ser2sock - charts/stable/storj-node - charts/stable/tailscale diff --git a/charts/incubator/romm/.helmignore b/charts/stable/romm/.helmignore similarity index 100% rename from charts/incubator/romm/.helmignore rename to charts/stable/romm/.helmignore diff --git a/charts/incubator/romm/CHANGELOG.md b/charts/stable/romm/CHANGELOG.md similarity index 100% rename from charts/incubator/romm/CHANGELOG.md rename to charts/stable/romm/CHANGELOG.md diff --git a/charts/incubator/romm/Chart.yaml b/charts/stable/romm/Chart.yaml similarity index 83% rename from charts/incubator/romm/Chart.yaml rename to charts/stable/romm/Chart.yaml index 6f4098a316d..029e9a6b056 100644 --- a/charts/incubator/romm/Chart.yaml +++ b/charts/stable/romm/Chart.yaml @@ -10,7 +10,7 @@ dependencies: version: 7.0.34 deprecated: false description: game library manager focused in retro gaming -home: https://truecharts.org/charts/incubator/romm +home: https://truecharts.org/charts/stable/romm icon: https://truecharts.org/img/hotlink-ok/chart-icons/romm.png keywords: - romm @@ -22,10 +22,10 @@ maintainers: url: https://truecharts.org name: romm sources: - - https://github.com/truecharts/charts/tree/master/charts/incubator/romm + - https://github.com/truecharts/charts/tree/master/charts/stable/romm - https://github.com/zurdi15/romm type: application -version: 0.1.0 +version: 1.0.0 annotations: truecharts.org/catagories: | - media diff --git a/charts/incubator/romm/README.md b/charts/stable/romm/README.md similarity index 100% rename from charts/incubator/romm/README.md rename to charts/stable/romm/README.md diff --git a/charts/incubator/romm/docs/installation_notes.md b/charts/stable/romm/docs/installation_notes.md similarity index 90% rename from charts/incubator/romm/docs/installation_notes.md rename to charts/stable/romm/docs/installation_notes.md index 75ea60c8de9..3fb1c8d2c8c 100644 --- a/charts/incubator/romm/docs/installation_notes.md +++ b/charts/stable/romm/docs/installation_notes.md @@ -1,12 +1,14 @@ # Installation Notes Set Client Id and Client Secret with the API key from [IGDB](https://api-docs.igdb.com/#about) -SteamGridDB API Key is still WIP and doesnt need to be set. +SteamGridDB API Key is WIP and can be optionally set. This app has two folder structures found [here](https://github.com/zurdi15/romm/blob/master/README.md#-folder-structure). Structure 1 (high priority) - roms folder at root of library folder: +Just set the library PVC to hostpath or nfs mount. + ```txt library/ ├─ roms/ diff --git a/charts/incubator/romm/icon.png b/charts/stable/romm/icon.png similarity index 100% rename from charts/incubator/romm/icon.png rename to charts/stable/romm/icon.png diff --git a/charts/incubator/romm/questions.yaml b/charts/stable/romm/questions.yaml similarity index 100% rename from charts/incubator/romm/questions.yaml rename to charts/stable/romm/questions.yaml diff --git a/charts/incubator/romm/templates/NOTES.txt b/charts/stable/romm/templates/NOTES.txt similarity index 100% rename from charts/incubator/romm/templates/NOTES.txt rename to charts/stable/romm/templates/NOTES.txt diff --git a/charts/incubator/romm/templates/common.yaml b/charts/stable/romm/templates/common.yaml similarity index 100% rename from charts/incubator/romm/templates/common.yaml rename to charts/stable/romm/templates/common.yaml diff --git a/charts/incubator/romm/values.yaml b/charts/stable/romm/values.yaml similarity index 100% rename from charts/incubator/romm/values.yaml rename to charts/stable/romm/values.yaml