From 9bcdf510ef6752c51b035705eb581feb7671bc34 Mon Sep 17 00:00:00 2001 From: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com> Date: Mon, 28 Aug 2023 23:46:37 -0400 Subject: [PATCH] fix(obs-ndi): Fix VNC_PASSWD (#11985) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Matches upstream/Dockerfile -> https://github.com/patrickstigler/docker-obs-ndi/blob/400fc92a0a6953feef3bee371f5e0c2cd23991e2/Dockerfile#L12 ⚒️ Fixes # **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/incubator/obs-ndi/Chart.yaml | 2 +- charts/incubator/obs-ndi/questions.yaml | 7 +++---- charts/incubator/obs-ndi/values.yaml | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/charts/incubator/obs-ndi/Chart.yaml b/charts/incubator/obs-ndi/Chart.yaml index 01cede70131..2ea00d62629 100644 --- a/charts/incubator/obs-ndi/Chart.yaml +++ b/charts/incubator/obs-ndi/Chart.yaml @@ -24,7 +24,7 @@ sources: - https://github.com/truecharts/charts/tree/master/charts/incubator/obs-ndi - https://github.com/patrickstigler/docker-obs-ndi type: application -version: 3.0.1 +version: 3.0.2 annotations: truecharts.org/SCALE-support: "true" truecharts.org/catagories: | diff --git a/charts/incubator/obs-ndi/questions.yaml b/charts/incubator/obs-ndi/questions.yaml index 15c4001eef0..922d85533ba 100644 --- a/charts/incubator/obs-ndi/questions.yaml +++ b/charts/incubator/obs-ndi/questions.yaml @@ -10,9 +10,6 @@ questions: # Include{replicas1} # Include{podSpec} # Include{containerMain} -# Include{containerBasic} -# Include{containerAdvanced} - - variable: env group: "App Configuration" label: "Image Environment" @@ -25,7 +22,9 @@ questions: description: "Enter your VNC password to login" schema: type: string - default: "123456" + default: "headless" +# Include{containerBasic} +# Include{containerAdvanced} # Include{containerConfig} # Include{podOptions} # Include{serviceRoot} diff --git a/charts/incubator/obs-ndi/values.yaml b/charts/incubator/obs-ndi/values.yaml index 8b28b50bcbd..935999226ab 100644 --- a/charts/incubator/obs-ndi/values.yaml +++ b/charts/incubator/obs-ndi/values.yaml @@ -28,7 +28,7 @@ workload: startup: type: tcp env: - VNC_PASSWD: "123456" + VNC_PASSWD: "headless" service: main: ports: