From 66699afcd139830cd4eb84fda487b2c07348fd35 Mon Sep 17 00:00:00 2001 From: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com> Date: Fri, 27 Oct 2023 14:37:35 -0400 Subject: [PATCH] fix(watchyourlan): Fix networking + capabilities (#13979) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Adds NET_RAW to enable ARP scanning and enables host-networking by default since it needs to bind to the interface to scan, otherwise this chart won't work like ever ⚒️ Fixes #13972 **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [X] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/stable/watchyourlan/Chart.yaml | 2 +- charts/stable/watchyourlan/values.yaml | 23 ++++++++++++++++------- 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/charts/stable/watchyourlan/Chart.yaml b/charts/stable/watchyourlan/Chart.yaml index 8d486d4d59a..642ffcaedf6 100644 --- a/charts/stable/watchyourlan/Chart.yaml +++ b/charts/stable/watchyourlan/Chart.yaml @@ -19,7 +19,7 @@ name: watchyourlan sources: - https://github.com/truecharts/charts/tree/master/charts/stable/watchyourlan - https://github.com/aceberg/WatchYourLAN -version: 5.0.6 +version: 5.1.0 annotations: truecharts.org/catagories: | - network diff --git a/charts/stable/watchyourlan/values.yaml b/charts/stable/watchyourlan/values.yaml index 27c22c1ad0c..04362e81cf6 100644 --- a/charts/stable/watchyourlan/values.yaml +++ b/charts/stable/watchyourlan/values.yaml @@ -2,7 +2,20 @@ image: repository: tccr.io/truecharts/watchyourlan tag: v1.0.4@sha256:d9e102b153f7195fd72c6d8da13633373948fcee60873ab531e939f42222945c pullPolicy: IfNotPresent -hostNetwork: true + +securityContext: + container: + readOnlyRootFilesystem: false + runAsNonRoot: false + runAsGroup: 0 + runAsUser: 0 + capabilities: + add: + - NET_RAW + +podOptions: + hostNetwork: true + watchyourlan: gui_ip: "0.0.0.0" interfaces: @@ -10,6 +23,7 @@ watchyourlan: theme: darkly timeout: 300 shoutrrr_url: "" + service: main: ports: @@ -23,12 +37,7 @@ persistence: portal: open: enabled: true -securityContext: - container: - readOnlyRootFilesystem: false - runAsNonRoot: false - runAsGroup: 0 - runAsUser: 0 + workload: main: podSpec: