From 406fc0c26be5efcfbe7955e1818db11a5db77a93 Mon Sep 17 00:00:00 2001 From: Todd Radel Date: Sat, 24 Jun 2023 07:32:04 -0400 Subject: [PATCH] bug(node-exporter): replace deprecated flags (#9857) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Replaces the deprecated `--collector.filesystem.ignore-mount-points` and `--collector.filesystem.ignore-fs-types` with `--collector.filesystem.mount-points-exclude` and `--collector.filesystem.fs-types-exclude`. ⚒️ Fixes #9856 **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [x] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** Tested on my local install of TrueNAS Scale. **📃 Notes:** None. **✔️ Checklist:** - [x] ⚖️ My code follows the style guidelines of this project - [x] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [x] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: Todd Radel Signed-off-by: Kjeld Schouten Co-authored-by: Kjeld Schouten --- charts/dependency/node-exporter/Chart.yaml | 2 +- charts/dependency/node-exporter/values.yaml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/dependency/node-exporter/Chart.yaml b/charts/dependency/node-exporter/Chart.yaml index b1b375f1a23..724d8be3bc5 100644 --- a/charts/dependency/node-exporter/Chart.yaml +++ b/charts/dependency/node-exporter/Chart.yaml @@ -21,7 +21,7 @@ name: node-exporter sources: - https://github.com/truecharts/charts/tree/master/charts/dependency/node-exporter type: application -version: 1.0.29 +version: 1.0.30 annotations: truecharts.org/catagories: | - metrics diff --git a/charts/dependency/node-exporter/values.yaml b/charts/dependency/node-exporter/values.yaml index 6f6db0bfb8d..4e4ddedd35e 100644 --- a/charts/dependency/node-exporter/values.yaml +++ b/charts/dependency/node-exporter/values.yaml @@ -21,8 +21,8 @@ workload: - --path.procfs=/hostproc - --path.sysfs=/hostsys - --web.listen-address=0.0.0.0:{{ .Values.service.main.ports.main.port }} - - --collector.filesystem.ignored-mount-points="^/(dev|proc|sys|var/lib/docker/.+|var/lib/kubelet/.+|var/db/system/.+|mnt/[a-zA-Z0-9-_\\.]+/ix-applications/.+)($|/)" - - --collector.filesystem.ignored-fs-types="^(autofs|binfmt_misc|cgroup|configfs|debugfs|devpts|devtmpfs|fusectl|hugetlbfs|mqueue|overlay|proc|procfs|pstore|rpc_pipefs|securityfs|sysfs|tracefs)$" + - --collector.filesystem.mount-points-exclude="^/(dev|proc|sys|var/lib/docker/.+|var/lib/kubelet/.+|var/db/system/.+|mnt/[a-zA-Z0-9-_\\.]+/ix-applications/.+)($|/)" + - --collector.filesystem.fs-types-exclude="^(autofs|binfmt_misc|cgroup|configfs|debugfs|devpts|devtmpfs|fusectl|hugetlbfs|mqueue|overlay|proc|procfs|pstore|rpc_pipefs|securityfs|sysfs|tracefs)$" - --collector.netdev.device-exclude="^veth.*$" - --collector.netclass.ignored-devices="^veth.*$" probes: