From 360f3f759b44da8d43aac84f564f5bbd9ab2fe35 Mon Sep 17 00:00:00 2001
From: sdimovv <36302090+sdimovv@users.noreply.github.com>
Date: Tue, 31 Oct 2023 22:17:46 +0000
Subject: [PATCH] feat(nextcloud): Add Force Enable Allow Local Remote Servers
 config (#14106)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

Ties in with https://github.com/truecharts/containers/pull/34009

Allows users to manually enable `allow_local_remote_servers` config.

**⚙️ Type of change**

- [X] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
Not tested

**📃 Notes:**
<!-- Please enter any other relevant information here -->

My particular use case is to allow Nextcloud to connect to an internal
HTTP endpoint (for OIDC discovery)

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [X] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: sdimovv <36302090+sdimovv@users.noreply.github.com>
Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
---
 charts/stable/nextcloud/Chart.yaml               | 2 +-
 charts/stable/nextcloud/questions.yaml           | 7 +++++++
 charts/stable/nextcloud/templates/_configmap.tpl | 1 +
 charts/stable/nextcloud/values.yaml              | 2 ++
 4 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/charts/stable/nextcloud/Chart.yaml b/charts/stable/nextcloud/Chart.yaml
index 46688ed9c4a..df0f80a5881 100644
--- a/charts/stable/nextcloud/Chart.yaml
+++ b/charts/stable/nextcloud/Chart.yaml
@@ -29,7 +29,7 @@ sources:
   - https://github.com/nextcloud/docker
   - https://github.com/nextcloud/helm
 type: application
-version: 22.0.50
+version: 22.1.0
 annotations:
   truecharts.org/category: cloud
   truecharts.org/SCALE-support: "true"
diff --git a/charts/stable/nextcloud/questions.yaml b/charts/stable/nextcloud/questions.yaml
index 814222b0d09..756b3ebcde9 100644
--- a/charts/stable/nextcloud/questions.yaml
+++ b/charts/stable/nextcloud/questions.yaml
@@ -78,6 +78,13 @@ questions:
                   required: true
                   $ref:
                     - "definitions/nodeIP"
+              - variable: force_enable_allow_local_remote_servers
+                label: Force Enable Allow Local Remote Servers
+                description:
+                  Enables 'allow_local_remote_servers' option
+                schema:
+                  type: boolean
+                  default: false
         - variable: files
           label: Files Configuration
           schema:
diff --git a/charts/stable/nextcloud/templates/_configmap.tpl b/charts/stable/nextcloud/templates/_configmap.tpl
index 272da5844f2..5a6a3e9f10b 100644
--- a/charts/stable/nextcloud/templates/_configmap.tpl
+++ b/charts/stable/nextcloud/templates/_configmap.tpl
@@ -148,6 +148,7 @@ nextcloud-config:
     NX_RUN_OPTIMIZE: {{ .Values.nextcloud.general.run_optimize | quote }}
     NX_DEFAULT_PHONE_REGION: {{ .Values.nextcloud.general.default_phone_region | quote }}
     NEXTCLOUD_DATA_DIR: {{ .Values.persistence.data.targetSelector.main.main.mountPath }}
+    NX_FORCE_ENABLE_ALLOW_LOCAL_REMOTE_SERVERS: {{ .Values.nextcloud.general.force_enable_allow_local_remote_servers | quote }}
 
     {{/* Files */}}
     NX_SHARED_FOLDER_NAME: {{ .Values.nextcloud.files.shared_folder_name | quote }}
diff --git a/charts/stable/nextcloud/values.yaml b/charts/stable/nextcloud/values.yaml
index 0973f228b04..a9ebb5dbb62 100644
--- a/charts/stable/nextcloud/values.yaml
+++ b/charts/stable/nextcloud/values.yaml
@@ -36,6 +36,8 @@ nextcloud:
     # IP used for exposing nextcloud,
     # often the loadbalancer IP
     accessIP: ""
+    # Allows Nextcloud to connect to unsecure (http) endpoints
+    force_enable_allow_local_remote_servers: false
   # File settings
   files:
     shared_folder_name: Shared