From 2dd5b595e21334eb8d376494d7b68df4910f95ee Mon Sep 17 00:00:00 2001
From: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com>
Date: Sun, 28 May 2023 11:11:29 -0400
Subject: [PATCH] fix(romm) fix persistence storage (#9221)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
fix an persistence  issue where roms wouldnt be read into the app.

its not a necessary a breaking change as the library mount was not
changed.

⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [X] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
---
 charts/incubator/romm/Chart.yaml     |  4 ++--
 charts/incubator/romm/questions.yaml | 12 ++++++------
 charts/incubator/romm/values.yaml    |  8 ++++----
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/charts/incubator/romm/Chart.yaml b/charts/incubator/romm/Chart.yaml
index d69bbfa3947..6f4098a316d 100644
--- a/charts/incubator/romm/Chart.yaml
+++ b/charts/incubator/romm/Chart.yaml
@@ -1,5 +1,5 @@
 apiVersion: v2
-appVersion: "1.8.1"
+appVersion: "1.8.4"
 dependencies:
   - name: common
     repository: https://library-charts.truecharts.org
@@ -25,7 +25,7 @@ sources:
   - https://github.com/truecharts/charts/tree/master/charts/incubator/romm
   - https://github.com/zurdi15/romm
 type: application
-version: 0.0.5
+version: 0.1.0
 annotations:
   truecharts.org/catagories: |
     - media
diff --git a/charts/incubator/romm/questions.yaml b/charts/incubator/romm/questions.yaml
index 19bad6ba639..a121d7bb98b 100644
--- a/charts/incubator/romm/questions.yaml
+++ b/charts/incubator/romm/questions.yaml
@@ -64,17 +64,17 @@ questions:
 # Include{serviceExpert}
 # Include{serviceList}
 # Include{persistenceRoot}
-        - variable: romm
-          label: App Romm Storage
-          description: Stores the Application Romm.
+        - variable: library
+          label: App Library Storage
+          description: Stores the Application Library.
           schema:
             additional_attrs: true
             type: dict
             attrs:
 # Include{persistenceBasic}
-        - variable: library
-          label: App Library Storage
-          description: Stores the Application Library.
+        - variable: resources
+          label: App Resources Storage
+          description: Stores the Application Resources.
           schema:
             additional_attrs: true
             type: dict
diff --git a/charts/incubator/romm/values.yaml b/charts/incubator/romm/values.yaml
index c519b539ed3..1f4a3471d4d 100644
--- a/charts/incubator/romm/values.yaml
+++ b/charts/incubator/romm/values.yaml
@@ -1,7 +1,7 @@
 image:
   repository: tccr.io/truecharts/romm
   pullPolicy: IfNotPresent
-  tag: v1.8.1@sha256:b8e1b4d352c223b73b049e48aa960827bc59e7587d5b64452a3fa99ca219f71f
+  tag: v1.8.4@sha256:2caadd52ad96c4f674030ea0176361e796fdc158c5f1eb48406863aa6e03ec4d
 
 securityContext:
   container:
@@ -53,12 +53,12 @@ service:
         port: 10680
 
 persistence:
-  romm:
-    enabled: true
-    mountPath: /romm
   library:
     enabled: true
     mountPath: /romm/library
+  resources:
+    enabled: true
+    mountPath: /romm/resources
 
 mariadb:
   enabled: true