From 184792d49d229b94a54f9fa7d73d1835ca1ce7f1 Mon Sep 17 00:00:00 2001 From: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com> Date: Sun, 31 Dec 2023 08:16:44 -0500 Subject: [PATCH] fix(xmrig): Remove extra env vars (#16587) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Removing pre set env vars ⚒️ Fixes # **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/stable/xmrig/Chart.yaml | 2 +- charts/stable/xmrig/questions.yaml | 12 ------------ charts/stable/xmrig/values.yaml | 2 -- 3 files changed, 1 insertion(+), 15 deletions(-) diff --git a/charts/stable/xmrig/Chart.yaml b/charts/stable/xmrig/Chart.yaml index 0d4f242b639..4d9419c9084 100644 --- a/charts/stable/xmrig/Chart.yaml +++ b/charts/stable/xmrig/Chart.yaml @@ -1,7 +1,7 @@ kubeVersion: ">=1.24.0-0" apiVersion: v2 name: xmrig -version: 4.1.0 +version: 4.1.1 appVersion: latest description: Chartised version of XMRig for CPU Mining. Helps turn your TrueNAS server into a Monero / cryptocurrency mining rig. Now optionally works with GPU algorithms as well. home: https://truecharts.org/charts/incubator/xmrig diff --git a/charts/stable/xmrig/questions.yaml b/charts/stable/xmrig/questions.yaml index 775106fb90f..93692423e20 100644 --- a/charts/stable/xmrig/questions.yaml +++ b/charts/stable/xmrig/questions.yaml @@ -63,18 +63,6 @@ questions: schema: type: string default: "" - - variable: NVIDIA_VISIBLE_DEVICES - label: "NVIDIA_VISIBLE_DEVICES" - description: "Nvidia Only Enter your GPU UUID here (only required if you plan to mine with an Nvidia GPU otherwise leave this empty. Dont forget to add --runtime=nvidia to your Extra Parameters in the Advanced View)." - schema: - type: string - default: "" - - variable: NVIDIA_DRIVER_CAPABILITIES - label: "NVIDIA_DRIVER_CAPABILITIES" - description: "Please leave this set to the default option of all if you arent sure what to put here. This value can be left in the template even if you dont want to mine with an Nvidia GPU." - schema: - type: string - default: "all" # Include{containerBasic} # Include{containerAdvanced} # Include{containerConfig} diff --git a/charts/stable/xmrig/values.yaml b/charts/stable/xmrig/values.yaml index 17315e52682..eb273e042d7 100644 --- a/charts/stable/xmrig/values.yaml +++ b/charts/stable/xmrig/values.yaml @@ -28,8 +28,6 @@ workload: DONATE: "1" DRIVERV: "" FEE: lnxd-fee - NVIDIA_DRIVER_CAPABILITIES: all - NVIDIA_VISIBLE_DEVICES: "" POOL: xmr-au1.nanopool.org:14444 WALLET: 84e8UJvXHDGVfE5HZDQfhn3Kh3RGJKebz31G7D4H24TLPMe9x7bQLBw8iyBhNx9USXB8MhvhBe3DyVW1LcuVAf4jBiADNLw WORKER: Unraid