From 03fdfed7b411a153e0581925c2bb967eaf9b5932 Mon Sep 17 00:00:00 2001 From: Malcolm <56974882+malcolmcdixon@users.noreply.github.com> Date: Tue, 13 Jun 2023 09:01:12 +0100 Subject: [PATCH] fix(questions): add missing `additional_attrs: true` (#9581) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** add missing additional_attrs: true in traefik and external-service, also fix misspelled label as per Stavros ⚒️ Fixes # **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ✔️] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/enterprise/traefik/questions.yaml | 1 + charts/stable/external-service/questions.yaml | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/charts/enterprise/traefik/questions.yaml b/charts/enterprise/traefik/questions.yaml index 64b7f79e99e..479a1af0d54 100644 --- a/charts/enterprise/traefik/questions.yaml +++ b/charts/enterprise/traefik/questions.yaml @@ -293,6 +293,7 @@ questions: - variable: tls label: "websecure Entrypoints Configuration" schema: + additional_attrs: true type: dict hidden: true attrs: diff --git a/charts/stable/external-service/questions.yaml b/charts/stable/external-service/questions.yaml index fc6137b8c61..b5c7c063873 100644 --- a/charts/stable/external-service/questions.yaml +++ b/charts/stable/external-service/questions.yaml @@ -90,8 +90,9 @@ questions: show_subquestions_if: true subquestions: - variable: annotations - label: "annoations" + label: "annotations" schema: + additional_attrs: true type: dict hidden: true attrs: